Move RapidsErrorUtils to org.apache.spark.sql.shims package
#5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
tgravescs
reviewed
Jun 5, 2022
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package com.nvidia.spark.rapids.shims | |||
| package org.apache.spark.sql.rapids.shims | |||
There was a problem hiding this comment.
we wouldn't need to move this one, correct? They only changed in 3.2.2 and later?
There was a problem hiding this comment.
please file a followup issue
tgravescs
approved these changes
Jun 5, 2022
Curious to know why this was merged to 22.08 and not 22.06. |
The fix is for Spark-3.2.2 which is as yet unreleased, so would not be targeted for 22.06. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Close #5744
The
QueryExecutionErrorshas been declared asprivate[sql]in Spark 330+ and Spark 321. Update the code to fix build error.