Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter profiling tool based on start time. #5918

Merged

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Jun 27, 2022

Closes: #4323

Added an option (--start-app-time and -s) in Profiling tool to filter event logs using application start time. This is similar to the one used in Qualification tools.

Examples:

  1. --start-app-time 1d <event-logs>
22/06/27 11:38:02 INFO FilterAppInfo: Parsing Event Log: file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514904001
22/06/27 11:38:02 INFO FilterAppInfo: Parsing Event Log: file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514789396
22/06/27 11:38:03 INFO FilterAppInfo: Total number of events parsed: 6 for file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514789396
22/06/27 11:38:03 INFO FilterAppInfo: Total number of events parsed: 6 for file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514904001
22/06/27 11:38:03 WARN ProfileMain: No event logs to process after checking paths, exiting!
  1. --start-app-time 1m <event-logs>
22/06/27 11:46:40 INFO FilterAppInfo: Parsing Event Log: file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514789396
22/06/27 11:46:40 INFO FilterAppInfo: Parsing Event Log: file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514904001
22/06/27 11:46:41 INFO FilterAppInfo: Total number of events parsed: 6 for file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514904001
22/06/27 11:46:41 INFO FilterAppInfo: Total number of events parsed: 6 for file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514789396
22/06/27 11:46:41 INFO Profiler: Threadpool size is 3
22/06/27 11:46:41 INFO ApplicationInfo: Parsing Event Log: file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514904001
22/06/27 11:46:41 INFO ApplicationInfo: Parsing Event Log: file:/Users/psarthi/Desktop/Work/profiling/event-logs/local-1655514789396

Signed-off-by : Partho Sarthi psarthi@nvidia.com

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@parthosa parthosa force-pushed the profiling-tool-filter-start-time branch from 164ce3f to 2ac2378 Compare June 27, 2022 19:51
@parthosa
Copy link
Collaborator Author

build

Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nartal1 nartal1 added the tools label Jun 27, 2022
@nartal1 nartal1 added this to the Jun 20 - Jul 8 milestone Jun 27, 2022
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@nartal1
Copy link
Collaborator

nartal1 commented Jun 27, 2022

Please update the profiling tool doc - https://github.com/NVIDIA/spark-rapids/blob/branch-22.08/docs/spark-profiling-tool.md#profiling-tool-options

Could you please push the updated spark-profiling-tool.md file in this PR.

Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
@nartal1
Copy link
Collaborator

nartal1 commented Jun 28, 2022

build

Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nartal1
Copy link
Collaborator

nartal1 commented Jun 28, 2022

build

@nartal1 nartal1 merged commit d986f64 into NVIDIA:branch-22.08 Jun 29, 2022
@parthosa parthosa deleted the profiling-tool-filter-start-time branch June 30, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Profiling tool add option to filter based on filesystem date
2 participants