-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter profiling tool based on start time. #5918
Filter profiling tool based on start time. #5918
Conversation
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
164ce3f
to
2ac2378
Compare
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the profiling tool doc - https://github.com/NVIDIA/spark-rapids/blob/branch-22.08/docs/spark-profiling-tool.md#profiling-tool-options
tools/src/test/scala/com/nvidia/spark/rapids/tool/profiling/AppFilterSuite.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/AppFilterImpl.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/AppFilterImpl.scala
Show resolved
Hide resolved
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Could you please push the updated |
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
build |
Closes: #4323
Added an option (
--start-app-time
and-s
) in Profiling tool to filter event logs using application start time. This is similar to the one used in Qualification tools.Examples:
--start-app-time 1d <event-logs>
--start-app-time 1m <event-logs>
Signed-off-by : Partho Sarthi psarthi@nvidia.com