Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix databricks test report location [databricks] #5936

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Jun 30, 2022

Signed-off-by: Peixin Li pxli@nyu.edu

Previous change passed premerge CI but fail to deal w/ nightly case.

in pre-merge: we build artifacts in place, and do not pass params.jar_path (LOCAL_JAR_PATH default as empty)
in nightly testing: we upload plugin artifacts to some dir and explicitly pass it as params.jar_path

This one is to going to fix the report path issue

Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi added bug Something isn't working test Only impacts tests labels Jun 30, 2022
@pxLi pxLi requested a review from zhanga5 as a code owner June 30, 2022 01:33
@pxLi
Copy link
Collaborator Author

pxLi commented Jun 30, 2022

build

Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxLi
Copy link
Collaborator Author

pxLi commented Jun 30, 2022

will keep monitoring future nightly runs

@pxLi pxLi merged commit f3d8b65 into NVIDIA:branch-22.08 Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants