Add fixed issues to regex fuzzer #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <antchang@nvidia.com>
…d-regex-choice-to-fuzzer
Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
build |
sameerz
added
the
task
andygrove
reviewed
Aug 1, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
|
LGTM. Left one code style suggestion. |
andygrove
previously approved these changes
Aug 2, 2022
Signed-off-by: Anthony Chang <antchang@nvidia.com>
…d-regex-choice-to-fuzzer
|
build |
andygrove
approved these changes
Aug 2, 2022
NVnavkumar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4603
This PR adds regex
|choice operator, octal chars in character classes, and escaped characters to character class ranges to the fuzzer, and fixes some corner cases from these updates:\x24for the character$, Java treats it like\$but cuDF treats it as the end of line anchor character, so we need to escape these characters in the transpilation.{0}and{0,0}) inside a capture group has some inconsistences so I have disabled them.