Enable anchors in regexp string split #6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
build |
jlowe
approved these changes
Jul 26, 2022
NVnavkumar
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4719
This took some time to grok but it appears like Java's implementation for
\z,$, and^in specifically string split is inconsistent with it's own implementation in find/replace.\z,$, and^do not respect new lines/line terminators in string split. Conveniently,\Zand\Ain cuDF also do not match line terminators so we can transpile to that.I also needed to disable repetitions of
\Ain split because of some fuzzer failures. I think it's possible to support it but I'm not sure how and it isn't a priority.Signed-off-by: Anthony Chang antchang@nvidia.com