Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spark2 Explain API code for 22.08 #6215

Merged
merged 16 commits into from
Aug 5, 2022

Conversation

tgravescs
Copy link
Collaborator

contributes to #6081
Note i'm not saying fixes since we are still checking things in we should do this check again when we actually code freeze.

Tested manually using the NDS 1 queries and diffing the output. Ran against a couple of different 2.4.x versions. Also ran a few various queries by hand.

This is used for allowing user on spark2 to get explain output to determine if query is good fit for gpu.. Just for reference, instructions on using this API are: https://nvidia.github.io/spark-rapids/docs/get-started/getting-started-workload-qualification.html#2-get-the-explain-output

@tgravescs tgravescs added the tools label Aug 3, 2022
@tgravescs tgravescs added this to the July 22 - Aug 5 milestone Aug 3, 2022
@tgravescs tgravescs self-assigned this Aug 3, 2022
@tgravescs
Copy link
Collaborator Author

build

Signed-off-by: Thomas Graves <tgraves@nvidia.com>
@tgravescs
Copy link
Collaborator Author

build

@tgravescs
Copy link
Collaborator Author

build

@tgravescs
Copy link
Collaborator Author

Updated to latest checked in

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really find it hard to review diffs of diffs, but I think it looks okay.

@tgravescs tgravescs merged commit 8dc5d3d into NVIDIA:branch-22.08 Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants