Support auto-compaction for Delta tables on [databricks] #7889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still bug: Compaction is not routed through GpuParquetFileFormat.
mythrocks
changed the title
Signed-off-by: MithunR <mythrocks@gmail.com>
mythrocks
force-pushed
the
rebased-auto-compact
branch
from
38cca11
to
9923a5b
Compare
Signed-off-by: MithunR <mythrocks@gmail.com>
andygrove
reviewed
Mar 15, 2023
...rk321db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuOptimizeExecutor.scala
Outdated
Show resolved
Hide resolved
Also, minor test refactor.
mythrocks
changed the title
|
Build |
|
Build |
This test is not valid, now that auto-compaction works.
|
Build |
jlowe
reviewed
Mar 17, 2023
...rk321db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuDoAutoCompaction.scala
Outdated
Show resolved
Hide resolved
...rk321db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuOptimizeExecutor.scala
Outdated
Show resolved
Hide resolved
...db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuOptimisticTransaction.scala
Outdated
Show resolved
Hide resolved
...rk330db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuDoAutoCompaction.scala
Outdated
Show resolved
Hide resolved
...db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuOptimisticTransaction.scala
Outdated
Show resolved
Hide resolved
...rk321db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuDoAutoCompaction.scala
Show resolved
Hide resolved
...rk330db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuOptimizeExecutor.scala
Outdated
Show resolved
Hide resolved
jlowe
reviewed
Mar 17, 2023
1. Attempted using databricks-specific post-commit hooks for auto compaction. Failed. 2. Changed support class names to use "Gpu" prefix. 3. Added/fixed code comments.
jlowe
reviewed
Mar 23, 2023
...rk321db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuDoAutoCompaction.scala
Outdated
Show resolved
Hide resolved
...rk330db/src/main/scala/com/databricks/sql/transaction/tahoe/rapids/GpuDoAutoCompaction.scala
Outdated
Show resolved
Hide resolved
integration_tests/src/main/python/delta_lake_auto_compact_test.py
Outdated
Show resolved
Hide resolved
Right. I'm still working on that. Unexpected issue on 10.4 that I'm trying to resolve first. |
I've updated this now. |
|
Build |
jlowe
reviewed
Mar 23, 2023
|
(Fixed the discrepancy in documentation. Resolved conflicts.) |
jlowe
reviewed
Mar 24, 2023
|
Transient failures in the Markdown links check: |
|
Build |
jlowe
approved these changes
Mar 24, 2023
|
Build |
|
I've merged this. Thank you for the reviews and guidance, @jlowe and @andygrove! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for auto-compaction of Delta tables on Databricks (11.3 and 10.4), via the
spark-rapidsplugin.This change is based on the work in the Delta IO project, specifically in PR#1156.
There are some deviations in the behaviour of auto-compaction on partitioned tables in this implementation, as compared to Databricks (11.3 at least). Specifically, it appears that Databricks does not seem to apply auto-compaction across all partitions uniformly. (It might have to do with the
spark.databricks.delta.autoCompact.targetsetting. This is still being investigated.)Note that auto-compaction is also only supported when writing to delta-directories. E.g.
Auto compaction does not trigger via SQL writes. (The
spark-pluginsupport for Delta Tables does not extend to replacing theorg.apache.spark.sql.execution.datasources.v2.AppendDataExecV1exec.)