Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support broadcast nested loop existence joins with no condition #9100

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

jlowe
Copy link
Contributor

@jlowe jlowe commented Aug 23, 2023

Fixes #9086. Adds code to handle unconditional nested loop existence joins in both the build left and build right cases along with tests.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe self-assigned this Aug 23, 2023
@jlowe
Copy link
Contributor Author

jlowe commented Aug 23, 2023

build

@sameerz sameerz added the bug Something isn't working label Aug 23, 2023
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. There is just a missing copyright update.

@jlowe
Copy link
Contributor Author

jlowe commented Aug 24, 2023

build

@jlowe
Copy link
Contributor Author

jlowe commented Aug 24, 2023

build

abellina
abellina previously approved these changes Aug 24, 2023
revans2
revans2 previously approved these changes Aug 24, 2023
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just a few nits

@jlowe jlowe dismissed stale reviews from revans2 and abellina via e656098 August 24, 2023 16:27
@jlowe
Copy link
Contributor Author

jlowe commented Aug 24, 2023

build

@jlowe
Copy link
Contributor Author

jlowe commented Aug 25, 2023

build

@jlowe jlowe merged commit 35f740c into NVIDIA:branch-23.10 Aug 25, 2023
@jlowe jlowe deleted the bnlj-exists-no-cond branch August 25, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GpuBroadcastNestedLoopJoinExec can assert in doUnconditionalJoin
4 participants