Expose host store spill #9189
Merged
Expose host store spill #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
revans2
previously approved these changes
Sep 5, 2023
jlowe
reviewed
Sep 5, 2023
| } | ||
| } | ||
|
|
||
| RapidsBufferCatalog.setDeviceStorage(devStore) |
There was a problem hiding this comment.
Do we need to close any previous RapidsBufferCatalog state that may have been leftover from a previous test before clobbering its settings here?
There was a problem hiding this comment.
Yes, that seems like a good idea. Will do.
sameerz
added
the
reliability
|
oh I see conflicts.. need to take a look |
|
build |
jlowe
approved these changes
Sep 6, 2023
revans2
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to the first part of #8881
This adds a method at the
RapidsBufferCatalogobject level that allows you to spill a store. It also exposes aRapidsBufferCatalog.getHostStoragemethod which can be used to trigger spill from anywhere at this level.