Fix host memory leak for R2C #9196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
jlowe
approved these changes
Sep 7, 2023
abellina
approved these changes
Sep 7, 2023
|
To be clear I believe that the leak only happens when an exception is thrown, like with a retry. So even though this is not a new leak it should be rare and not worth fixing in older versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed during some integration test runs that the logs were complaining about a host memory leak.
I tracked it down and we were not closing the GpuColumnarBatchBuilder in all cases. I cleaned up some of the cases when we were closing it at the end, and fixed the ones where we were not doing it.