Enable a couple of retry asserts in internal row to cudf row iterator suite #9251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… suite Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
revans2
reviewed
Sep 18, 2023
| @@ -85,16 +85,13 @@ class GeneratedInternalRowToCudfRowIteratorRetrySuite | |||
| ctriter, schema, TargetSize(Int.MaxValue), | |||
| NoopMetric, NoopMetric, NoopMetric, NoopMetric, NoopMetric)) | |||
| RmmSpark.forceRetryOOM(RmmSpark.getCurrentThreadId, 2) | |||
| assertResult(0)(RmmSpark.getAndResetNumRetryThrow(RmmSpark.getCurrentThreadId)) | |||
| assertResult(0)(RmmSpark.getAndResetNumRetryThrow(1)) | |||
There was a problem hiding this comment.
I don't understand why we are using a thread ID of 1? Could you at least add some comments explaining what is happening here?
There was a problem hiding this comment.
That's actually taskId, and that was my confusion. I'll add a comment. This task id is what we told RmmSpark we wanted to associate RmmSpark.getCurrentThreadId to in the RmmSparkRetrySuiteBase.beforeEach method.
There was a problem hiding this comment.
That's right I forgot my own APIs.
|
build |
revans2
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9168
This is a follow on from #9169. It turns out the asserts work fine if only I had passed the right argument,
taskId, instead ofthreadId. Human error.