-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building different Cuda versions section profile does not take effect [skip ci] #9328
Building different Cuda versions section profile does not take effect [skip ci] #9328
Conversation
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
fc8ecb3
to
1d3a4dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks we removed these profiles in #3411 probably with the rationale that the profiles whose whole content is just one property do not add much value
build |
CONTRIBUTING.md
Outdated
You can build against different versions of the CUDA Toolkit by using one of the following profiles: | ||
* `-Pcuda11` (CUDA 11.0/11.1/11.2, default) | ||
You can build against different versions of the CUDA Toolkit by modifying the variable `cuda.version`: | ||
* `-Dcuda.version=cuda11` (CUDA 11.0/11.1/11.2, default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit,
* `-Dcuda.version=cuda11` (CUDA 11.0/11.1/11.2, default) | |
* `-Dcuda.version=cuda11` (set to `cuda11` for CUDA 11.x, or `cuda12` for CUDA 12.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuda12 should be on a separate line. This already has the list-of-1 problem, so might as well lean into the fact that it's a list of values and add a new entry.
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
build |
Fixes #9327
No unit tests needed as it is a minor doc change.
I have one question regarding this change , whether we did intend having or had cuda versions as profiles in maven pom settings and if that is preferred over current change? CC: @gerashegalov