Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result type computation in exec::when_any #978

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Fix result type computation in exec::when_any #978

merged 1 commit into from
Jun 17, 2023

Conversation

maikel
Copy link
Collaborator

@maikel maikel commented Jun 17, 2023

There is a missing __munique within the variant computation. I also added a test that catches this for me.

@rapids-bot
Copy link

rapids-bot bot commented Jun 17, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

@ericniebler
Copy link
Collaborator

/ok to test

@ericniebler ericniebler merged commit 82cb445 into NVIDIA:main Jun 17, 2023
10 checks passed
@ericniebler
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericniebler ericniebler ericniebler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maikel @ericniebler