Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

missing #include <stdexcept> in thrust/detail/contiguous_storage.h #1262

Closed
hpcdgrie opened this issue Aug 26, 2020 · 5 comments
Closed

missing #include <stdexcept> in thrust/detail/contiguous_storage.h #1262

hpcdgrie opened this issue Aug 26, 2020 · 5 comments
Assignees
Milestone

Comments

@hpcdgrie
Copy link

This does not compile with MSVC 14

@alliepiper
Copy link
Collaborator

alliepiper commented Aug 27, 2020

I'll add the header, but heads up that MSVC 2015 is no longer supported and is likely to stop working with Thrust's main github branch soon.

The version of Thrust that ships with the CUDA TK will continue to support MSVC2015 with deprecation warnings for now, but that's only temporary. Consider migrating to MSVC 2017 or 2019.

@alliepiper alliepiper self-assigned this Aug 27, 2020
@alliepiper alliepiper added this to the 1.10.0 milestone Aug 27, 2020
@hpcdgrie
Copy link
Author

Ok, thank your. Sorry for the confusion with the MSVC version. I meant the version that ships with Visual Studio 2019 and as far as I know that is MSVC 14.X.

@hpcdgrie
Copy link
Author

And I made a mistake: it ist the contiguous_storage.inl file that misses the #include for the use of std::runtime_error, not the header.

@alliepiper
Copy link
Collaborator

No worries, the MSVC toolchain versioning is weird and nonsensical. 14 could refer to:

  • MSVC 2005 (_MSC_VER == 1400)
  • MSVC 2015 (VS 14.0)
  • MSVC 2015/2017/2019 (MSVC++ 14.x)

So much fun.

alliepiper added a commit to alliepiper/thrust that referenced this issue Sep 1, 2020
alliepiper added a commit that referenced this issue Sep 3, 2020
@alliepiper
Copy link
Collaborator

Fixed in #1265.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants