This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Don't call the destruction kernel for an empty vector #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Internal CI has passed. Merging this. |
brycelelbach
deleted the
bug/nvbug-2720132-avoid-destroy-for-empty-vector
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When destroying a Thrust vector, we should avoid calling
destroyif the vector is empty. For adevice_vector, destroy calls into parallel algorithm machinery, which doesn't currently early exit (or early exit enough) for empty ranges.This is a fix for Bug 2720132.