Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add unit test for inclusive_scan with User Defined Type #1070

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

codereport
Copy link
Collaborator

This is the corresponding unit test that will test for the struct + inclusive_scan fixed here: https://github.com/thrust/cub/pull/13 For more details, read the description / fix for that bug

@codereport codereport added the type: enhancement New feature or request. label Mar 12, 2020
@codereport codereport requested review from alliepiper and griwes March 12, 2020 23:34
@codereport codereport self-assigned this Mar 12, 2020
testing/scan.cu Outdated Show resolved Hide resolved
@alliepiper
Copy link
Collaborator

These new changes will need to be wrapped in

#if THRUST_CPP_DIALECT >= 2011
// ...
#endif // c++11

since pre-C++11 won't be able to support {} initialization.

@codereport
Copy link
Collaborator Author

These new changes will need to be wrapped in

#if THRUST_CPP_DIALECT >= 2011
// ...
#endif // c++11

since pre-C++11 won't be able to support {} initialization.

Done :)

@alliepiper alliepiper self-requested a review March 18, 2020 16:28
@alliepiper
Copy link
Collaborator

Rebased and added submodule update to use thrust/cub#13.

Internal CI launched for shelve 28141734.

@alliepiper alliepiper merged commit ebc90b0 into NVIDIA:master Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants