This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Modernize scan_by_key functors / type deductions. #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Use `InitialValueType` or `InputValueIteratorType` for value accumulation, consistent with P0571 and the regular scans. 2) Use transparent `thrust::equal_to<>` and `thrust::plus<>` specializations instead of the explicitly typed functors. 3) Value-initialize the initial-value type. This fixes and adds a test for issue NVIDIA#1374.
|
run tests |
|
DVS CL: 29542409 |
alliepiper
added
testing: internal ci in progress
alliepiper
added
testing: gpuCI passed
alliepiper
added
testing: internal ci passed
brycelelbach
approved these changes
Jan 27, 2021
|
run tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitialValueTypeorInputValueIteratorTypefor valueaccumulation, consistent with P0571 and the regular scans.
instead of the explicitly typed functors.
This fixes and adds a test for issue #1374.