Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Increase contrast of search input text in docs. #1644

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

bdice
Copy link
Collaborator

@bdice bdice commented Mar 23, 2022

See related fix to libcudacxx: NVIDIA/libcudacxx#258

This PR increases the contrast of the documentation's search bar text so that the input text is legible.

If reviewers are aware of other instances of this issue beyond libcudacxx/thrust, let me know and I can make corresponding updates to other repositories.

I verified that this fix works for Firefox, Chrome, and Edge browsers. All three browsers show light text on a dark background in the placeholder text and when input is entered.

Before, without input (Firefox):
image

After, without input (Firefox):
image

After, with input (Chrome):
image

@alliepiper
Copy link
Collaborator

Thanks! I'll go ahead and merge this to stay sync'd with libcu++. Pinging @brycelelbach for awareness.

If reviewers are aware of other instances of this issue beyond libcudacxx/thrust, let me know and I can make corresponding updates to other repositories.

AFAIK those are the only two projects that use this scheme.

@alliepiper alliepiper merged commit 51e7cec into NVIDIA:main Mar 24, 2022
@alliepiper alliepiper added this to the 1.17.0 milestone May 5, 2022
@alliepiper alliepiper added type: enhancement New feature or request. P2: nice to have Desired, but not necessary. area: docs Related to documentation. labels May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to documentation. P2: nice to have Desired, but not necessary. type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants