Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix thrust::reduce_by_key for 2^31 elements #1671

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Fix thrust::reduce_by_key for 2^31 elements #1671

merged 1 commit into from
Apr 29, 2022

Conversation

gevtushenko
Copy link
Collaborator

This PR addresses the following issue.

@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko gevtushenko requested a review from alliepiper April 27, 2022 15:01
@alliepiper alliepiper added type: bug: functional Does not work as intended. P1: should have Necessary, but not critical. labels Apr 27, 2022
@alliepiper alliepiper added this to the 1.17.0 milestone Apr 27, 2022
alliepiper
alliepiper approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline, but nothing blocking. LGTM.

testing/cuda/reduce_by_key.cu Outdated Show resolved Hide resolved
testing/cuda/reduce_by_key.cu Outdated Show resolved Hide resolved
@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label Apr 27, 2022
@alliepiper alliepiper linked an issue Apr 27, 2022 that may be closed by this pull request
thrust::reduce_by_key error for 2^31 elements #1609
Closed
@gevtushenko gevtushenko force-pushed the fix-main/github/reduce_by_int_overflow branch from c3e5523 to 9ef3a8e Compare April 28, 2022 22:02
@gevtushenko
Copy link
Collaborator Author

run tests

@gevtushenko gevtushenko added testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Apr 29, 2022
@gevtushenko gevtushenko merged commit 892e13a into NVIDIA:main Apr 29, 2022
@lilohuang lilohuang mentioned this pull request Nov 14, 2022
Closed
@gevtushenko gevtushenko mentioned this pull request Nov 14, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees
No one assigned
Labels
P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing. type: bug: functional Does not work as intended.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

thrust::reduce_by_key error for 2^31 elements
2 participants
@gevtushenko @alliepiper