Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

remove deprecated support for the THRUST_DEVICE_BACKEND macro #1761

Merged
merged 3 commits into from
Aug 8, 2022
Merged

remove deprecated support for the THRUST_DEVICE_BACKEND macro #1761

merged 3 commits into from
Aug 8, 2022

Conversation

ericniebler
Copy link
Collaborator

fixes #60

@ericniebler ericniebler added P2: nice to have Desired, but not necessary. type: cleanup Modernization, dead code removal, style fixes, etc. labels Aug 4, 2022
@ericniebler
Copy link
Collaborator Author

run tests

@ericniebler ericniebler requested a review from alliepiper August 4, 2022 21:17
@alliepiper alliepiper added this to the 2.0.0 milestone Aug 4, 2022
alliepiper
alliepiper previously requested changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM, but we'll need to also make the same change to thrust/detail/config/host_system.h.

@ericniebler
Copy link
Collaborator Author

These changes LGTM, but we'll need to also make the same change to thrust/detail/config/host_system.h.

Uh, these are the changes to thrust/detail/config/host_system.h. 😕

@miscco
Copy link
Collaborator

miscco commented Aug 5, 2022 •
edited
Loading

These changes LGTM, but we'll need to also make the same change to thrust/detail/config/host_system.h.

Uh, these are the changes to thrust/detail/config/host_system.h. 😕

Those changes live in thrust/detail/config/device_system.h

The same code is also here

thrust/thrust/detail/config/host_system.h

Lines 35 to 47 in 0bebe52

#ifdef THRUST_HOST_BACKEND
# if THRUST_HOST_COMPILER == THRUST_HOST_COMPILER_MSVC
# pragma message("------------------------------------------------------------------------------")
# pragma message("| WARNING: THRUST_HOST_BACKEND is deprecated; use THRUST_HOST_SYSTEM instead |")
# pragma message("------------------------------------------------------------------------------")
# else
# warning ------------------------------------------------------------------------------
# warning | WARNING: THRUST_HOST_BACKEND is deprecated; use THRUST_HOST_SYSTEM instead |
# warning ------------------------------------------------------------------------------
# endif // THRUST_HOST_COMPILER
# undef THRUST_HOST_SYSTEM
# define THRUST_HOST_SYSTEM THRUST_HOST_BACKEND
#endif // THRUST_HOST_BACKEND

@ericniebler
Copy link
Collaborator Author

🤦‍♂️

BTW, there is a comment in thrust/memory.h that references THRUST_DEFAULT_DEVICE_BACKEND. What should that be now?

@ericniebler ericniebler force-pushed the remove-THRUST_DEVICE_BACKEND branch from 82d037e to df32883 Compare August 5, 2022 21:40
@ericniebler
Copy link
Collaborator Author

run tests

@ericniebler ericniebler requested a review from alliepiper August 5, 2022 21:41
@ericniebler ericniebler dismissed alliepiper’s stale review August 5, 2022 21:42

I addressed the review comments

@ericniebler ericniebler merged commit 32ffb6e into NVIDIA:main Aug 8, 2022
@ericniebler ericniebler deleted the remove-THRUST_DEVICE_BACKEND branch August 8, 2022 15:41
@alliepiper alliepiper added the release: breaking change Include in "Breaking Changes" section of release notes. label Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miscco miscco miscco approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper

Assignees
No one assigned
Labels
P2: nice to have Desired, but not necessary. release: breaking change Include in "Breaking Changes" section of release notes. type: cleanup Modernization, dead code removal, style fixes, etc.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

remove Thrust 1.6.0 deprecations
3 participants
@ericniebler @miscco @alliepiper