Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specification of target glossiness to configuration #359

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch reverts a hard-coded glossiness assumption that was previously used in FPSci. Targets and session/experiment level config can now specify their gloss and targetGloss respectively with per-target gloss overriding the global settings (similar to target color configuration).

@bboudaoud-nv bboudaoud-nv added the enhancement New feature or request label Apr 11, 2022
@bboudaoud-nv bboudaoud-nv requested a review from jspjutNV April 11, 2022 17:52
@bboudaoud-nv bboudaoud-nv self-assigned this Apr 11, 2022
@bboudaoud-nv bboudaoud-nv marked this pull request as ready for review April 11, 2022 18:35
@jspjutNV jspjutNV added this to the Next Release (mid 2022) milestone Apr 11, 2022
@jspjutNV
Copy link
Contributor

jspjutNV commented Apr 11, 2022

In an effort to document how to retain the old behavior, I'm going to make this comment, and update it to have the right config settings to keep the old behavior. I'll put this comment into the release notes.

In each target, add the following:

gloss = Color4(0.4f, 0.2f, 0.1f, 0.8f);

Or, in the experiment or session add the following:

targetGloss = Color4(0.4f, 0.2f, 0.1f, 0.8f);

@jspjutNV jspjutNV merged commit 78976e2 into master Apr 11, 2022
@jspjutNV jspjutNV deleted the TargetMaterialFix branch April 11, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants