Pre-play audio on first load #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though #275 isn't fixed, I still believe this is a good perf win. @bboudaoud-nv , if you could take a look and see if you agree or disagree we could potentially merge this soon. |
bboudaoud-nv
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
This fix is as good as any for the current model of loading sounds in FPSci. However adding sounds to the soundTable in the set[X]Sound() methods for the Targets is weird. In the future we probably want to build up soundTable at config load and just preplay all audio directly from here. This is a fine fix for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes audio play when first loaded to avoid stuttering when it first needs to play.
When finished, closes #375
With some luck may also help #275 , but it doesn't fix that yet.