-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a two interval forced choice sample #401
Conversation
I suggest we wait until merging the |
This came from the |
76c97aa has a version using the pre-task-level configuration style of specification. |
As of 2279276 there appears to be an issue updating the status and the results db with this experiment, and I'm not sure what's going wrong. @bboudaoud-nv , the error I'm getting is the following (from
The rest of the sql appears to succeed. I didn't go back and check if this was happening before I switched to task level. I suspect this isn't directly related to this experiment, but maybe it's a mistake in the experiment finding an issue we have a work around for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sample seems fine. I'd be tempted to exclude the scene
config since it just uses default values, but otherwise seems fine to me.
I removed parts of the scene config (left the name for easier adjustment for people who want to change the scene). I also increased the target size slightly since it was a bit more difficult than the purpose of this sample justified. |
This PR adds a sample of 2 interval forced choice. This sample should probably be updated once #392 is merged, but should work fine for earlier versions of FPSci.