Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a two interval forced choice sample #401

Merged
merged 9 commits into from
Jan 10, 2023
Merged

Add a two interval forced choice sample #401

merged 9 commits into from
Jan 10, 2023

Conversation

jspjutNV
Copy link
Contributor

This PR adds a sample of 2 interval forced choice. This sample should probably be updated once #392 is merged, but should work fine for earlier versions of FPSci.

@jspjutNV jspjutNV added the enhancement New feature or request label Nov 30, 2022
@jspjutNV jspjutNV added this to the Near future release (2022) milestone Nov 30, 2022
@jspjutNV jspjutNV self-assigned this Nov 30, 2022
@bboudaoud-nv
Copy link
Collaborator

I suggest we wait until merging the TaskFlow branch then make this example use tasks to implement the 2IFC model. This sample could still be useful, but I'd like to know more about why certain things are done (i.e., logToSingleDb = False is fairly uncommon, so I'd like to avoid providing samples w/ behavior that is atypical for FPSci configuration).

@jspjutNV
Copy link
Contributor Author

jspjutNV commented Dec 9, 2022

logToSingleDb = False is fairly uncommon, so I'd like to avoid providing samples w/ behavior that is atypical for FPSci configuration

This came from the 1hit_sa2019 sample that I started this one from. There's probably a bunch of other stuff that could be dropped. I'll clean it up once we get to the task-level version. As is, it's still nice to have this around as an example of the old-style 2 interval forced choice design.

@jspjutNV
Copy link
Contributor Author

jspjutNV commented Jan 9, 2023

76c97aa has a version using the pre-task-level configuration style of specification.

@jspjutNV
Copy link
Contributor Author

jspjutNV commented Jan 9, 2023

As of 2279276 there appears to be an issue updating the status and the results db with this experiment, and I'm not sure what's going wrong. @bboudaoud-nv , the error I'm getting is the following (from log.txt):

User selected session: 60hz_delay. Updating now...
Warning insert rows with empty row value array ignored!
Warning insert rows with empty row value array ignored!
Warning insert rows with empty row value array ignored!
Warning insert rows with empty row value array ignored!
Creating table Experiments w/ SQL query:CREATE TABLE IF NOT EXISTS Experiments ( description TEXT NOT NULL ,time TEXT NOT NULL ,hash TEXT NOT NULL ,config TEXT NOT NULL );

Error in INSERT INTO statement (INSERT INTO Experiments VALUES('2IFC',): near "s": syntax error

The rest of the sql appears to succeed. I didn't go back and check if this was happening before I switched to task level. I suspect this isn't directly related to this experiment, but maybe it's a mistake in the experiment finding an issue we have a work around for.

Copy link
Collaborator

@bboudaoud-nv bboudaoud-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample seems fine. I'd be tempted to exclude the scene config since it just uses default values, but otherwise seems fine to me.

@jspjutNV jspjutNV mentioned this pull request Jan 10, 2023
@jspjutNV
Copy link
Contributor Author

I removed parts of the scene config (left the name for easier adjustment for people who want to change the scene).

I also increased the target size slightly since it was a bit more difficult than the purpose of this sample justified.

@jspjutNV jspjutNV merged commit 6a73a2e into master Jan 10, 2023
@jspjutNV jspjutNV deleted the 2IFC_Sample branch January 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants