Fix for crash on load w/ experiment complete #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this PR is still in draft state just to be sure it's the type of solution to the problem that we really want. If so, I'll start looking at it. |
|
Yeah, exactly. I don't think it will create any negative impacts but certainly worth deciding if this is the behavior we want. |
jspjutNV
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trial-level configuration the
playerCamerawas not initialized in FPSci when loading a completed experiment. This caused null pointer exceptions when runningoneFrame(). This branch assigns theplayerCameraand adds null checking to avoid these exceptions while still displaying theallSessionsCompleteFeedbackmessage.