-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module cmake fxn #252
Closed
Closed
Module cmake fxn #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Play into module_cmake_fxn
Absolute hash comparisons are commented out, these can be enabled once we can verify hash values are portable. Unit tests that compare hashes relative to each other are branched depending on the type info is hashed, or not. Currently we use BPHASH_USE_TYPEID option to enable/disable adding type name to the hash.
* starts any_result_wrapper [skip ci] * result works, starting input [skip ci] * back-up [skip ci] * any_input_wrapper is unit tested [skip ci] * pimpls are r2g
* starts any_result_wrapper [skip ci] * result works, starting input [skip ci] * back-up [skip ci] * any_input_wrapper is unit tested [skip ci] * pimpls are r2g * back-up [skip ci] * merge master [skip ci] * back-up [skip ci] * any_input/any_field r2g
* Update CMakeLists to enable unit tests for dependencies This will not change the default behavior of not building tests for dependencies. One needs to set these variables explicitly in the toolchain file `set(PARALLELZONE_BUILD_TESTING ON)`, or as a command line argument for cmake `cmake -DPARALLELZONE_BUILD_TESTING=ON`. * Add default values, revert external dependency option
* initial attempt at clearer error messages for static_assert * remove extra property type from tests * cleanup verbose static_assert struct * moved to new header under property_type/detail_ * cleaned up class description
* back-up * back-up of the design [skip ci] * back up of database notes [skip ci] * clarifies fragility of hashes [skip ci] * clarify fragility of hashes [skip ci] * almost got a plan [skip ci] * g2g * Committing clang-format changes * clarifications * adds memcached client Co-authored-by: Clang Robot <robot@example.com>
* back-up [skip ci] * backing-up refactor [skip ci] * back up for today [skip ci] * rocksdb_pimpl documented and tested [skip ci] * re-enables public API [skip ci] * backup [skip ci] * back up [skip ci] * r2g
* back-up progress [skip ci] * uuid lgtm
* rewrites any_input/any_result * refactor database under cache * remove extra files * Committing clang-format changes Co-authored-by: Clang Robot <robot@example.com>
* adds a runtime to module base * add runtime to ModuleManager
* updates any_field * adds documentation
While this generation code works, I want to point out that there are quite a few (104) warnings that get thrown during the
|
Does this really touch 95 files? If not can you update your local copy of master and rebase onto that? |
I'll give that a shot. It definitely doesn't touch that many files. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
This PR completes and is based on PR #206, create some CMake infrastructure for automatically generating module documentation. This is intended to be used as part of the CI documentation website generation.
As part of the documentation, I included an example of how to use the planned API in a CMake project and how to generate the subsequent documentation website using Sphinx, even if it is not the top-level documentation.
TODOs