compose and style data dictionary HTML #1296
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonmcc
force-pushed
the
dm-metadata-pdf
branch
from
f380550
to
c2139d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
=======================================
Coverage 69.67% 69.67%
=======================================
Files 111 111
Lines 5913 5913
Branches 659 659
=======================================
Hits 4120 4120
Misses 1661 1661
Partials 132 132 ☔ View full report in Codecov by Sentry. |
damonmcc
force-pushed
the
dm-metadata-pdf
branch
4 times, most recently
from
9b365ce
to
762c33b
Compare
damonmcc
force-pushed
the
dm-metadata-pdf
branch
from
762c33b
to
45db96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #561
follow-up to #1269
These changes use the new approach for generating HTML/PDFs from metadata yml:
These changes do not apply all of the formatting seen in the Figma designs. I got stuck with nesting html elements and getting the text to wrap correctly so I focused on creating/using modular jinja files for a data dictionary.
Tested changes by running Template DB export stage locally and looking at the PDF and here's the PDF generated by the PR Template DB build data_dictionary.pdf.
TODOs