Ingest Migration - Scripts #1302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvankrieken
force-pushed
the
fvk-ingest-scripts
branch
2 times, most recently
from
688ba8c to
d6c8c24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
+ Coverage 69.83% 70.05% +0.22%
==========================================
Files 110 109 -1
Lines 5900 5881 -19
Branches 659 658 -1
==========================================
Hits 4120 4120
+ Misses 1648 1629 -19
Partials 132 132 ☔ View full report in Codecov by Sentry. |
fvankrieken
force-pushed
the
fvk-ingest-scripts
branch
from
d6c8c24 to
dcde3fc
Compare
|
Closing in favor of some smaller-scope prs since some of these are requiring downstream code changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1290
Code changes for facdb build - preprocessor for bpl_libraries broke the "position" column into lat long. Interestingly, this was already done in the source script in
library, and also none of these columns are actually used in the build (I looked through code and ran a successful build. So I dropped the lines referencing them (since they're converted to geom and dropped in ingest).