Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default version strategy for colp, knownprojects #1304

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

fvankrieken
Copy link
Contributor

@fvankrieken fvankrieken commented Dec 5, 2024

fixes issue here (side note - not sure what's going wrong with issue creation failure. I feel like sporadic things like this happen, if this persists next week we can check it out)

This seemed like the least evil option. You can always provide a version manually, COLP does follow this convention even if it's not montly, and KPDB it seems we don't have a versioning scheme set up, so when we set it up we can change this

Fixed run (past planning step)

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (f68cdf3) to head (693e24a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   69.83%   69.83%           
=======================================
  Files         110      110           
  Lines        5900     5900           
  Branches      659      659           
=======================================
  Hits         4120     4120           
  Misses       1648     1648           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fvankrieken fvankrieken merged commit e7bdf5a into main Dec 6, 2024
46 checks passed
@fvankrieken fvankrieken deleted the fvk-patch branch December 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants