Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node 16; upgrade CircleCI configuration #1110

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

allthesignals
Copy link
Collaborator

@allthesignals allthesignals commented Aug 8, 2022

Summary

Bump the node version and also use a newer node image in CircleCI.

Tasks/Bug Numbers

Technical Explanation

Specifies a node version in a few ways: using .nvmrc and using "engines" key in package.json.

Also bumps the node version in CI.

Note: I'm not sure how this affects the production environment. If we're still using Heroku, we should check that it uses the right buildpack.

Any other info you think would help a reviewer understand this PR?

@allthesignals allthesignals requested a review from a team as a code owner August 8, 2022 04:22
@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for applicant-portal ready!

Name Link
🔨 Latest commit bc87da1
🔍 Latest deploy log https://app.netlify.com/sites/applicant-portal/deploys/630e259b8e7afe00084e32d1
😎 Deploy Preview https://deploy-preview-1110--applicant-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@allthesignals allthesignals force-pushed the 1109-bump-node-version branch from db11df2 to 7ae2f5c Compare August 23, 2022 19:35
@TylerMatteo
Copy link
Collaborator

@allthesignals Looks like some more commits have hit develop since you opened this. Can you rebase your branch and push? Aside from that, this looks good to me. Glad to see that this seems to have been pretty straight forward. I'll initiate the merge, just so I can make sure we're traffic managing with those other commits in develop.

We can do some smoke testing once this is merged into develop, I'll let you know if anything comes up. I'm pretty sure Heroku will determine the node version to use based on the new value in .nvmrc so hopefully any problems from that become apparent when we deploy develop.

@godfreyyeung godfreyyeung force-pushed the 1109-bump-node-version branch from 7ae2f5c to bc87da1 Compare August 30, 2022 14:58
@godfreyyeung godfreyyeung merged commit f807fce into develop Aug 30, 2022
@godfreyyeung godfreyyeung deleted the 1109-bump-node-version branch August 30, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applicant Portal Back End
3 participants