Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sign up banner #1115

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Remove sign up banner #1115

merged 1 commit into from
Jan 12, 2024

Conversation

TylerMatteo
Copy link
Contributor

Removing the sign up banner for user interviews.

@TylerMatteo TylerMatteo requested a review from a team as a code owner January 12, 2024 18:42
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for labs-factfinder ready!

Name Link
🔨 Latest commit d6ab1f9
🔍 Latest deploy log https://app.netlify.com/sites/labs-factfinder/deploys/65a1881b5fd1b3000849adf3
😎 Deploy Preview https://deploy-preview-1115--labs-factfinder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerMatteo TylerMatteo merged commit 26ed2ad into develop Jan 12, 2024
4 of 5 checks passed
TylerMatteo added a commit that referenced this pull request Feb 14, 2024
* Epic/13898 pff (#1097)

* make start:local-api command

* update readme with start:local-api command

* update table variables that changed

* Place shells of tables
Fill pop table with variables

* add mutually-exclusive table variables

* place all decennial variables into tables

* remove space from decennial male var

* add formatting to tables. remove unused tables

* write tooltips

* bar charts

* Updated label to complete AB#14528

* Added much of CCD selection type functionality required for map page

* update choropleths with abbreviated variables

* SASS division updated

* Implemented correct selection explode functionality for CCDs

* point to remote api and local layers

* Updated selection summary for CCDs at the top of data explorer page.

* Disabled ACS in dropdown for CCDs

* Specify decimal places for pop density
Remove special property for decennial props

* use divider type for empty rows

* Updated about page text. Completes AB#14714

* Fix for attempting to load ACS data for geotypes without ACS data. Completes AB#14496.

* update census topics in explorer

* Updated map layers portion of About page

* remove percent from special variables

* Added pop pyramid for census data. Completes AB#14724

* Updated Decennial Census text.

* check whether previous sum is null

* hide percents for special variables

* mark ratios as special

* Upgraded packages

* Revert "point to remote api and local layers"

This reverts commit 1c67326.

---------

Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>

* Bugs/epic 13898 (#1099)

* remove moe from decennial pop pyramid

* fix pop pyramid for previous years

* Task 14578
Dialog text for Fall 2023 DHC updates

* prevent the rendering of 2010 census household type chart

* prevent any decennial comparisons from being marked insignificant

* Epic/13898 pff (#1097) (#1098) (#1101)

* make start:local-api command

* update readme with start:local-api command

* update table variables that changed

* Place shells of tables
Fill pop table with variables

* add mutually-exclusive table variables

* place all decennial variables into tables

* remove space from decennial male var

* add formatting to tables. remove unused tables

* write tooltips

* bar charts

* Updated label to complete AB#14528

* Added much of CCD selection type functionality required for map page

* update choropleths with abbreviated variables

* SASS division updated

* Implemented correct selection explode functionality for CCDs

* point to remote api and local layers

* Updated selection summary for CCDs at the top of data explorer page.

* Disabled ACS in dropdown for CCDs

* Specify decimal places for pop density
Remove special property for decennial props

* use divider type for empty rows

* Updated about page text. Completes AB#14714

* Fix for attempting to load ACS data for geotypes without ACS data. Completes AB#14496.

* update census topics in explorer

* Updated map layers portion of About page

* remove percent from special variables

* Added pop pyramid for census data. Completes AB#14724

* Updated Decennial Census text.

* check whether previous sum is null

* hide percents for special variables

* mark ratios as special

* Upgraded packages

* Revert "point to remote api and local layers"

This reverts commit 1c67326.

---------

Co-authored-by: Tyler Matteo <tylermatteo434@gmail.com>
Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>

* remove banner text for archive note

* Add banner with link to sign up for user interviews

* Remove margin from info banner

* Remove sign up banner (#1115)

* issue/16067 updated initial pop-up greeting with new copy

---------

Co-authored-by: Timothy Miller <miller.tim108@gmail.com>
Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>
Co-authored-by: Tyler Matteo <tylermatteo434@gmail.com>
TylerMatteo added a commit that referenced this pull request Mar 11, 2024
* Epic/13898 pff (#1097)

* make start:local-api command

* update readme with start:local-api command

* update table variables that changed

* Place shells of tables
Fill pop table with variables

* add mutually-exclusive table variables

* place all decennial variables into tables

* remove space from decennial male var

* add formatting to tables. remove unused tables

* write tooltips

* bar charts

* Updated label to complete AB#14528

* Added much of CCD selection type functionality required for map page

* update choropleths with abbreviated variables

* SASS division updated

* Implemented correct selection explode functionality for CCDs

* point to remote api and local layers

* Updated selection summary for CCDs at the top of data explorer page.

* Disabled ACS in dropdown for CCDs

* Specify decimal places for pop density
Remove special property for decennial props

* use divider type for empty rows

* Updated about page text. Completes AB#14714

* Fix for attempting to load ACS data for geotypes without ACS data. Completes AB#14496.

* update census topics in explorer

* Updated map layers portion of About page

* remove percent from special variables

* Added pop pyramid for census data. Completes AB#14724

* Updated Decennial Census text.

* check whether previous sum is null

* hide percents for special variables

* mark ratios as special

* Upgraded packages

* Revert "point to remote api and local layers"

This reverts commit 1c67326.

---------

Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>

* Bugs/epic 13898 (#1099)

* remove moe from decennial pop pyramid

* fix pop pyramid for previous years

* Task 14578
Dialog text for Fall 2023 DHC updates

* prevent the rendering of 2010 census household type chart

* prevent any decennial comparisons from being marked insignificant

* Epic/13898 pff (#1097) (#1098) (#1101)

* make start:local-api command

* update readme with start:local-api command

* update table variables that changed

* Place shells of tables
Fill pop table with variables

* add mutually-exclusive table variables

* place all decennial variables into tables

* remove space from decennial male var

* add formatting to tables. remove unused tables

* write tooltips

* bar charts

* Updated label to complete AB#14528

* Added much of CCD selection type functionality required for map page

* update choropleths with abbreviated variables

* SASS division updated

* Implemented correct selection explode functionality for CCDs

* point to remote api and local layers

* Updated selection summary for CCDs at the top of data explorer page.

* Disabled ACS in dropdown for CCDs

* Specify decimal places for pop density
Remove special property for decennial props

* use divider type for empty rows

* Updated about page text. Completes AB#14714

* Fix for attempting to load ACS data for geotypes without ACS data. Completes AB#14496.

* update census topics in explorer

* Updated map layers portion of About page

* remove percent from special variables

* Added pop pyramid for census data. Completes AB#14724

* Updated Decennial Census text.

* check whether previous sum is null

* hide percents for special variables

* mark ratios as special

* Upgraded packages

* Revert "point to remote api and local layers"

This reverts commit 1c67326.

---------

Co-authored-by: Tyler Matteo <tylermatteo434@gmail.com>
Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>

* remove banner text for archive note

* Add banner with link to sign up for user interviews

* Remove margin from info banner

* Remove sign up banner (#1115)

* issue/16067 updated initial pop-up greeting with new copy

* Add missing comma to netlify.toml

* Remove signup banner (#1142)

* Remove sign up banner

* Update to env to fix citynet issue

* Issue/16067 PFF Updates Trunk Branch (#1135)

* Population FactFinder 2018-2022 ACS & 2020 DDHC-A Updates

* issue 1130 updated category stops

* issue 1129 updated category stops for Pop65pl

* Issue 1125 update year references

* issue/1138 update copy on special note in data source menu

* issue/1138 update copy on special note in data source menu

* Revert "issue/1138 update copy on special note in data source menu"

This reverts commit 5e749f7.
"This reverts the pre-update banner message already in develop"

* issue/1127 updated and added to asian subgroups

* Issue 1125 remove extra end quotations

* issue 1146 Updated ACS Places of Birth

* Issue 1132
 - Added Detailed Race and Ethnicity (DT&E) decennial variables
 - DT&E variables are loaded and viewed when viewing data

* Issue 1133 added sub header text to DT&E header

* Issue 1124 Update about page copy

* Issue#1128 display acs data for ccds

* fix build issue on netlifty

---------

Co-authored-by: pratishta <ypradhi9@gmail.com>

* Updated pop-up copy

---------

Co-authored-by: Timothy Miller <miller.tim108@gmail.com>
Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>
Co-authored-by: horatio <horatiorosa@aol.com>
Co-authored-by: Horatio <HRosa@planning.nyc.gov>
Co-authored-by: pratishta <ypradhi9@gmail.com>
bmarchena pushed a commit that referenced this pull request Apr 25, 2024
* Epic/13898 pff (#1097)

* make start:local-api command

* update readme with start:local-api command

* update table variables that changed

* Place shells of tables
Fill pop table with variables

* add mutually-exclusive table variables

* place all decennial variables into tables

* remove space from decennial male var

* add formatting to tables. remove unused tables

* write tooltips

* bar charts

* Updated label to complete AB#14528

* Added much of CCD selection type functionality required for map page

* update choropleths with abbreviated variables

* SASS division updated

* Implemented correct selection explode functionality for CCDs

* point to remote api and local layers

* Updated selection summary for CCDs at the top of data explorer page.

* Disabled ACS in dropdown for CCDs

* Specify decimal places for pop density
Remove special property for decennial props

* use divider type for empty rows

* Updated about page text. Completes AB#14714

* Fix for attempting to load ACS data for geotypes without ACS data. Completes AB#14496.

* update census topics in explorer

* Updated map layers portion of About page

* remove percent from special variables

* Added pop pyramid for census data. Completes AB#14724

* Updated Decennial Census text.

* check whether previous sum is null

* hide percents for special variables

* mark ratios as special

* Upgraded packages

* Revert "point to remote api and local layers"

This reverts commit 1c67326.

---------

Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>

* Bugs/epic 13898 (#1099)

* remove moe from decennial pop pyramid

* fix pop pyramid for previous years

* Task 14578
Dialog text for Fall 2023 DHC updates

* prevent the rendering of 2010 census household type chart

* prevent any decennial comparisons from being marked insignificant

* Epic/13898 pff (#1097) (#1098) (#1101)

* make start:local-api command

* update readme with start:local-api command

* update table variables that changed

* Place shells of tables
Fill pop table with variables

* add mutually-exclusive table variables

* place all decennial variables into tables

* remove space from decennial male var

* add formatting to tables. remove unused tables

* write tooltips

* bar charts

* Updated label to complete AB#14528

* Added much of CCD selection type functionality required for map page

* update choropleths with abbreviated variables

* SASS division updated

* Implemented correct selection explode functionality for CCDs

* point to remote api and local layers

* Updated selection summary for CCDs at the top of data explorer page.

* Disabled ACS in dropdown for CCDs

* Specify decimal places for pop density
Remove special property for decennial props

* use divider type for empty rows

* Updated about page text. Completes AB#14714

* Fix for attempting to load ACS data for geotypes without ACS data. Completes AB#14496.

* update census topics in explorer

* Updated map layers portion of About page

* remove percent from special variables

* Added pop pyramid for census data. Completes AB#14724

* Updated Decennial Census text.

* check whether previous sum is null

* hide percents for special variables

* mark ratios as special

* Upgraded packages

* Revert "point to remote api and local layers"

This reverts commit 1c67326.

---------

Co-authored-by: Tyler Matteo <tylermatteo434@gmail.com>
Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>

* remove banner text for archive note

* Add banner with link to sign up for user interviews

* Remove margin from info banner

* Remove sign up banner (#1115)

* issue/16067 updated initial pop-up greeting with new copy

* Add missing comma to netlify.toml

* Remove signup banner (#1142)

* Remove sign up banner

* Update to env to fix citynet issue

* Issue/16067 PFF Updates Trunk Branch (#1135)

* Population FactFinder 2018-2022 ACS & 2020 DDHC-A Updates

* issue 1130 updated category stops

* issue 1129 updated category stops for Pop65pl

* Issue 1125 update year references

* issue/1138 update copy on special note in data source menu

* issue/1138 update copy on special note in data source menu

* Revert "issue/1138 update copy on special note in data source menu"

This reverts commit 5e749f7.
"This reverts the pre-update banner message already in develop"

* issue/1127 updated and added to asian subgroups

* Issue 1125 remove extra end quotations

* issue 1146 Updated ACS Places of Birth

* Issue 1132
 - Added Detailed Race and Ethnicity (DT&E) decennial variables
 - DT&E variables are loaded and viewed when viewing data

* Issue 1133 added sub header text to DT&E header

* Issue 1124 Update about page copy

* Issue#1128 display acs data for ccds

* fix build issue on netlifty

---------

Co-authored-by: pratishta <ypradhi9@gmail.com>

* Updated pop-up copy

---------

Co-authored-by: Timothy Miller <miller.tim108@gmail.com>
Co-authored-by: dhochbaum-dcp <dhochbaum@planning.nyc.gov>
Co-authored-by: horatio <horatiorosa@aol.com>
Co-authored-by: Horatio <HRosa@planning.nyc.gov>
Co-authored-by: pratishta <ypradhi9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant