SFR-2449: Add GTM scripts #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiequach
requested review from
samanthaandrews and
kylevillegas93
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
commented
Jan 7, 2025
| @@ -19,6 +19,14 @@ class MyDocument extends Document<DocumentProps> { | |||
| <Html lang="en"> | |||
| <Head> | |||
| <script src={appConfig.analytics} async /> | |||
| {/* Google Tag Manager */} | |||
| {/* eslint-disable-next-line @next/next/next-script-for-ga */} | |||
There was a problem hiding this comment.
Next third party scripts is available in Next 14
There was a problem hiding this comment.
Nice. Do you think it makes sense to upgrade to Next 15 sometime soon?
There was a problem hiding this comment.
Yes, we should also migrate to the app router to improve load states.
samanthaandrews
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR does the following:
Testing requirements & instructions: