SFR-2403: Add rollback step #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiequach
requested review from
samanthaandrews and
kylevillegas93
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+70
to
+71
| MANIFEST=$(aws ecr batch-get-image --repository-name $ECR_REPOSITORY --image-ids imageTag="production-latest" --output json | jq --raw-output --join-output '.images[0].imageManifest') | ||
| aws ecr put-image --repository-name $ECR_REPOSITORY --image-tag "production-previous" --image-manifest "$MANIFEST" |
There was a problem hiding this comment.
nice - i like this!
.github/workflows/full-ci-cd.yml
Outdated
| @@ -23,3 +23,42 @@ jobs: | |||
| needs: run_e2e_tests | |||
| uses: NYPL/sfr-bookfinder-front-end/.github/workflows/build-production.yaml@main | |||
| secrets: inherit | |||
|
|
|||
| # Rollback job in case of failure (Revert production to the previous task definition) | |||
| rollback: | |||
There was a problem hiding this comment.
What are your thoughts on creating a separate workflow for the rollback?
I think you'll need to add an on block:
on:
workflow_dispatch:
...
kylevillegas93
approved these changes
Jan 10, 2025
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR does the following:
Testing requirements & instructions: