Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds vendor bundling #487

Merged
merged 7 commits into from
Jun 5, 2017
Merged

Adds vendor bundling #487

merged 7 commits into from
Jun 5, 2017

Conversation

delambo
Copy link
Member

@delambo delambo commented May 23, 2017

RFC #315

kyt build produces a vendor, manifest, and main bundle. Also adds the webpack-assets-manifest in place of assets-webpack-plugin for a better looking asset manifest.

This will be a breaking change and will require a minor version upgrade.

Copy link
Contributor

@ccpricenytimes ccpricenytimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need good docs. Otherwise 👍

@ccpricenytimes ccpricenytimes merged commit 8433412 into master Jun 5, 2017
@ccpricenytimes ccpricenytimes deleted the adds-vendor-bundling branch June 5, 2017 20:04
tizmagik added a commit that referenced this pull request Jun 9, 2017
* master:
  Add Prettier + ESLint Integration (#480)
  Adds 0.6.0 final version (#498)
  adds 060-rc.1 (#497)
  webpack 2.6.1 (#496)
  Adds vendor bundling (#487)
  Adds 0.6.0 alpha (#488)
  chore: webpack & friends dep refresh (#482)

# Conflicts:
#	package.json
#	packages/babel-preset-kyt-core/yarn.lock
#	packages/babel-preset-kyt-react/yarn.lock
#	packages/kyt-cli/yarn.lock
#	packages/kyt-core/package.json
#	packages/kyt-core/yarn.lock
#	packages/kyt-starter-static/starter-src/yarn.lock
#	packages/kyt-starter-universal/starter-src/yarn.lock
#	yarn.lock
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants