Add Prettier + ESLint Integration #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what additional dependencies I need to add such that the Travis build will work again. I thought |
staylor
reviewed
Jun 7, 2017
| @@ -42,6 +44,11 @@ | |||
| "imports": "always-multiline", | |||
| "exports": "always-multiline", | |||
| "functions": "never" | |||
| }], | |||
| "prettier/prettier": ["error", { | |||
| "printWidth": 100, | |||
staylor
suggested changes
Jun 7, 2017
delambo
approved these changes
Jun 8, 2017
tizmagik
added a commit
that referenced
this pull request
Jun 9, 2017
* master: Add Prettier + ESLint Integration (#480) Adds 0.6.0 final version (#498) adds 060-rc.1 (#497) webpack 2.6.1 (#496) Adds vendor bundling (#487) Adds 0.6.0 alpha (#488) chore: webpack & friends dep refresh (#482) # Conflicts: # package.json # packages/babel-preset-kyt-core/yarn.lock # packages/babel-preset-kyt-react/yarn.lock # packages/kyt-cli/yarn.lock # packages/kyt-core/package.json # packages/kyt-core/yarn.lock # packages/kyt-starter-static/starter-src/yarn.lock # packages/kyt-starter-universal/starter-src/yarn.lock # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #445
This PR adds the following enhancements:
.eslintrc.jsonto configure Prettier for 100-character line length, single quotes, and ES5-style trailing commas (which I think is the closest approximation of the existingcomma-danglerules)Note:
eslint-config-prettierdisables ESLint rules that might conflict with Prettier, whileeslint-plugin-prettierruns Prettier (and passes it a config) as part of the linting process.Also, ESLint and its ruleset covers more than just code formatting, so it's appropriate to use both ESLint and Prettier together, rather than replace one with the other.