Fix two backwards compatibility bugs #528
Conversation
1. The local config file text says that `table_name` is being deprecated in favor of `assignments_table_name` and that `assignments_table_name` is preferred if both defined. However, only `table_name` was being used. An entry into the backwards_compatibility list in psiturk_config.py was added for this. 2. In the psiturk_config.py loop through the backwards compatibilities, the section was being hard-coded to `Hit Configuration`. This prevented fix in (1) from taking effect. It also was preventing the backwards compatibility setting for the logfiles from taking effect.
|
Again test_amt.py is failing. |
|
Hrm, idk about that test offhand, but that's a lot of failing tests. Concerning. I'll try to debug within the next few days. |
| ] | ||
| for bc in backwards_compatibilities: | ||
| env_key = f'PSITURK_{bc["prefer_this"].upper()}' | ||
| if env_key in os.environ: | ||
| self.set(bc['in_section'], bc['over_this'], os.environ.get(env_key)) | ||
| else: | ||
| preferred = self.get('HIT Configuration', bc['prefer_this'], fallback=None) |
There was a problem hiding this comment.
yikes, how was this ever working!
|
I cloned master, created a new conda environments (3.6 and 3.7) with master as the pip -e installed version of psiturk, and I am getting matching fails for test_amt.py: Whatever the problem is, it isn't my patch. |
|
Since the same code that worked a few months ago now fails, I'm guessing some dependency released a new version that is compatible with psiturk's requirements, which is now breaking things. Looking into it. |
|
Got'em, closeio/ciso8601#108 |
|
Wait what are we doing, we shouldn't be doing any of this today! Hacktoberfest doesn't start until tomorrow! |
table_nameis being deprecated in favor ofassignments_table_nameand thatassignments_table_nameis preferred if both defined. However, onlytable_namewas being used. An entry into the backwards_compatibility list in psiturk_config.py was added for this.Hit Configuration. This prevented fix in (1) from taking effect. It also was preventing the backwards compatibility setting for the logfiles from taking effect.