Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe and update identity provider #146

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Conversation

idoseemplicity
Copy link

No description provided.

@pvizeli
Copy link
Member

pvizeli commented Jul 29, 2022

please fix black

@pvizeli pvizeli merged commit 7a0e61c into NabuCasa:master Jul 31, 2022
Copy link

@nk9 nk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, but I noticed a potential issue with this PR. @pvizeli @idoseemplicity

Updates an existing identity provider
:param pool_id: The user pool ID
:param provider_name: The identity provider name
:return: dict of identity provider
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method doesn't actually seem to return anything?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this was already fixed with PR #148

@@ -866,6 +866,30 @@ def admin_create_identity_provider(
**kwargs,
)

def admin_describe_identity_provider(self, pool_id, provider_name):
"""
Updates an existing identity provider
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the describe method, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants