Use same username as challenge parameters #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please address the CI issue |
|
All tests passing now ;) |
mdecuir
pushed a commit
to MDmetrix/pycognito
that referenced
this pull request
Jun 30, 2021
* Use same username as challenge parameters * Adjusted layout * Fixes for tests * Fixes for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the username in the auth initiate and the username returned in the challenge response did not match.
This is noted as an issue when using an email or some other alias to initiate the change password auth flow (specifically used after admin_create_user) but the username returned in the challenge parameters is the actual username (ie sub) not the alias (ie email or phone).