-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom XNCP protocol commands #57
Custom XNCP protocol commands #57
Conversation
b3d2ef2
to
e1e4123
Compare
One PM: manually setting one source router is making problems if the rout is being broken and the network cant healing therefor its normally automatic or no source routing being used. |
Right now, For zigpy's source routing, we assume symmetry and just use the last-taken route from a device as the source route when sending to the device. This can definitely be improved (speculative routing, randomization, better discovery, etc.). |
New feature for firmware builders: overriding the board name. This uses a custom XNCP command so it will require support in bellows but it will allow you to override the firmware name that is displayed within Home Assistant: c_defines:
XNCP_BOARD_NAME: '"My Board v1.0"'
XNCP_MANUF_NAME: '"Some Manufacturer"' Currently, the board and device name are stored in |
625af16
to
0d19db4
Compare
The bellows side of this is done, just needs unit tests (zigpy/bellows#611). |
@puddly Is there an easy way to build this for the sonoff-e dongle as well? I'm wondering if it might help with the group command issues in home-assistant/core#86411 edit: sorry I meant zbdongle-e, I always get them mixed up |
0d19db4
to
a2f13ad
Compare
I'm going to go ahead and merge this. Without software explicitly running the custom commands, the only user-visible change will be arbitrary group packets "just working". |
This PR introduces custom XNCP commands to extend EmberZNet with useful functionality:
To facilitate future firmware extensions and to allow applications communicating with the firmware to query these firmware extensions, I've implemented a simple protocol using EZSP's
customFrame
command.