Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat build-time warnings as errors #72

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Jun 7, 2024

Enables -Wall -Wextra -Werror and fixes a few warnings and bugs with compilation.

There is a persistent warning with the PTI interface that can only be fixed if PTI is re-enabled verbosely in every config. I think this is a bug, as this component cannot be excluded:

// <<< sl:start pin_tool >>>
// <pti signal=DOUT,(DFRAME),(DCLK)> SL_RAIL_UTIL_PTI
// $[PTI_SL_RAIL_UTIL_PTI]
#ifndef SL_RAIL_UTIL_PTI_PERIPHERAL             
#warning "RAIL PTI peripheral not configured"
#define SL_RAIL_UTIL_PTI_PERIPHERAL              PTI
#endif

Until this is fixed in the Gecko SDK, this warning is explicitly disabled.

@puddly puddly requested a review from agners June 18, 2024 22:43
Copy link
Collaborator

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

src/ot-rcp/app.c Outdated Show resolved Hide resolved
src/ot-rcp/app.c Outdated Show resolved Hide resolved
@puddly
Copy link
Collaborator Author

puddly commented Jun 21, 2024

Looks like there may be some SLC-CLI flakiness. Happened only a single time so far so I'll deal with it if it happens again.

@puddly puddly merged commit 50c3d29 into NabuCasa:main Jun 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants