no message

ONVIF Discovery/module.php

@@ -223,8 +223,6 @@ protected function Discover()
     }
     protected function DiscoverDevices()
     {
-        //IPS_Sleep(5000);
-        //return []; // testing
         $Interfaces = $this->getIPAdresses();
         $uuid = self::uuidV4();
         $discoveryMessage = str_replace('[UUID]', $uuid, self::WS_DISCOVERY_MESSAGE);
@@ -527,6 +525,8 @@ private function getIPAdresses()
         $InterfaceDescriptions = array_column($Interfaces, 'Description', 'InterfaceIndex');
         $Networks = net_get_interfaces();
         $Addresses = [];
+        $Addresses['ipv6'] = [];
+        $Addresses['ipv4'] = [];
         foreach ($Networks as $InterfaceDescription => $Interface) {
             if (!$Interface['up']) {
                 continue;

ONVIF Media Stream/module.php

@@ -1210,7 +1210,7 @@ protected function WritePTZInHTMLBox()
             file_get_contents(__DIR__ . '/../libs/PTZControl.js')
         );
 
-        $JSCode = '<script>' . $JS . /*'initPTZ(' . $this->InstanceID . ');*/'</script>';
+        $JSCode = '<script>' . $JS . /*'initPTZ(' . $this->InstanceID . ');*/ '</script>';
         $HTMLData = '<div class="extended"><div class="ipsContainer media">' .
         $ImgSrc .
         '<div style="position:absolute; right:0px; bottom:0px; margin:10px">' .

library.json

@@ -7,6 +7,6 @@
         "version": "6.1"
     },
     "version": "2.13",
-    "build": 213,
-    "date": 1702047058
+    "build": 214,
+    "date": 1706077404
 }

libs/ONVIFModuleBase.php

@@ -63,31 +63,12 @@ public function Destroy()
 
     public function ApplyChanges()
     {
-        $EventTopic = $this->ReadPropertyString(\ONVIF\Device\Property::EventTopic);
-        $SyncEvents = ($EventTopic != $this->EventTopic);
         //Never delete this line!
         parent::ApplyChanges();
+
         $this->RegisterMessage($this->InstanceID, FM_CONNECT);
         $this->RegisterMessage($this->InstanceID, FM_DISCONNECT);
-
-        if ($EventTopic == '') {
-            $TopicFilter = '.*"Topic":"NOTHING".*';
-        } else {
-            $TopicFilter = '.*"Topic":"' . preg_quote(substr(json_encode($EventTopic), 1, -1)) . '.*';
-        }
-        $this->SetReceiveDataFilter($TopicFilter);
-        $this->SendDebug('SetReceiveDataFilter', $TopicFilter, 0);
-
-        if (IPS_GetKernelRunlevel() != KR_READY) {
-            return;
-        }
-        $this->RegisterParent();
-        $Events = $this->GetEvents($EventTopic);
-        $this->WriteAttributeArray(\ONVIF\Device\Attribute::EventProperties, $Events);
-        if ($SyncEvents && ($this->HasActiveParent())) {
-            $this->$EventTopic = $EventTopic;
-            IPS_RunScriptText('IPS_RequestAction(' . $this->InstanceID . ',"SetSynchronizationPoint",true);');
-        }
+        $this->InitFilterAndEvents();
     }
 
     public function RequestAction($Ident, $Value)
@@ -113,12 +94,35 @@ public function MessageSink($TimeStamp, $SenderID, $Message, $Data)
                 break;
         }
     }
+    protected function InitFilterAndEvents()
+    {
+        $EventTopic = $this->ReadPropertyString(\ONVIF\Device\Property::EventTopic);
+        $SyncEvents = ($EventTopic != $this->EventTopic);
+        if ($EventTopic == '') {
+            $TopicFilter = '.*"Topic":"NOTHING".*';
+        } else {
+            $TopicFilter = '.*"Topic":"' . preg_quote(substr(json_encode($EventTopic), 1, -1)) . '.*';
+        }
+        $this->SetReceiveDataFilter($TopicFilter);
+        $this->SendDebug('SetReceiveDataFilter', $TopicFilter, 0);
+
+        if (IPS_GetKernelRunlevel() != KR_READY) {
+            return;
+        }
+        $this->RegisterParent();
+        $Events = $this->GetEvents($EventTopic);
+        $this->WriteAttributeArray(\ONVIF\Device\Attribute::EventProperties, $Events);
+        if ($SyncEvents && ($this->HasActiveParent())) {
+            $this->$EventTopic = $EventTopic;
+            IPS_RunScriptText('IPS_RequestAction(' . $this->InstanceID . ',"SetSynchronizationPoint",true);');
+        }
+    }
 
     protected function KernelReady()
     {
         $this->RegisterParent();
         if ($this->HasActiveParent()) {
-            $this->ApplyChanges();
+            $this->InitFilterAndEvents();
         }
     }
 
@@ -134,7 +138,7 @@ protected function IOChangeState($State)
     {
         if ($State == IS_ACTIVE) {
             $this->EventTopic = $this->ReadPropertyString(\ONVIF\Device\Property::EventTopic);
-            $this->ApplyChanges();
+            $this->InitFilterAndEvents();
             $this->ReloadForm();
         }
     }