added another Bic8 test (PR068)

NaluKit · Dec 2, 2020 · 0bd8b06 · 0bd8b06
1 parent 69af7f1
commit 0bd8b06
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 6 deletions.
diff --git a/iban4g-gwt2-tests/src/test/java/com/github/nalukit/iban4g/shared/BicTest.java b/iban4g-gwt2-tests/src/test/java/com/github/nalukit/iban4g/shared/BicTest.java
@@ -111,8 +111,10 @@ public void testBicConstructionWithValueOfShouldReturnBic() {
   }
 
   public void testBicShouldReturnBic8Code() {
-    Bic bic = Bic.valueOf("DEUTDEFF500");
+    Bic bic01 = Bic.valueOf("DEUTDEFF500");
+    assertEquals(bic01.getBic8(), "DEUTDEFF");
 
-    assertEquals(bic.getBic8(), "DEUTDEFF");
+    Bic bic02 = Bic.valueOf("DEUTDEFF");
+    assertEquals(bic02.getBic8(), "DEUTDEFF");
   }
 }
diff --git a/iban4g-j2cl-tests/src/test/java/com/github/nalukit/iban4g/shared/BicTest.java b/iban4g-j2cl-tests/src/test/java/com/github/nalukit/iban4g/shared/BicTest.java
@@ -124,8 +124,10 @@ public void testBicConstructionWithValueOfShouldReturnBic() {
 
   @Test
   public void bicShouldReturnBic8Code() {
-    Bic bic = Bic.valueOf("DEUTDEFF500");
+    Bic bic01 = Bic.valueOf("DEUTDEFF500");
+    assertEquals(bic01.getBic8(), "DEUTDEFF");
 
-    assertEquals(bic.getBic8(), "DEUTDEFF");
+    Bic bic02 = Bic.valueOf("DEUTDEFF");
+    assertEquals(bic02.getBic8(), "DEUTDEFF");
   }
 }
diff --git a/iban4g-tests/src/test/java/com/github/nalukit/iban4g/shared/BicTest.java b/iban4g-tests/src/test/java/com/github/nalukit/iban4g/shared/BicTest.java
@@ -122,9 +122,11 @@ public void bicToStringShouldReturnString() {
 
   @Test
   public void bicShouldReturnBic8Code() {
-    Bic bic = Bic.valueOf("DEUTDEFF500");
+    Bic bic01 = Bic.valueOf("DEUTDEFF500");
+    assertThat(bic01.getBic8(), is(equalTo("DEUTDEFF")));
 
-    assertThat(bic.getBic8(), is(equalTo("DEUTDEFF")));
+    Bic bic02 = Bic.valueOf("DEUTDEFF");
+    assertThat(bic02.getBic8(), is(equalTo("DEUTDEFF")));
   }
 
   @RunWith(Parameterized.class)

diff --git a/iban4g/src/main/java/com/github/nalukit/iban4g/shared/Bic.java b/iban4g/src/main/java/com/github/nalukit/iban4g/shared/Bic.java
@@ -77,6 +77,7 @@ public String getLocationCode() {
   public String getBic8() {
     return getBankCode() + getCountryCode() + getLocationCode();
   }
+
   /**
    * Returns the branch code from the Bic.
    *
-Original file line number
+Diff line change
@@ Expand Up / @@ -77,6 +77,7 @@ public String getLocationCode() { @@
       public String getBic8() {
         return getBankCode() + getCountryCode() + getLocationCode();
       }
       /**
        * Returns the branch code from the Bic.
        *
@@ Expand Down @@