Update testing infrastructure #2612
Comments
thecodejunkie
changed the title
@thecodejunkie, the FakeItEasy packages on NuGet.org do not support .NET Core. The packages that target .NET Standard 1.6 can only be had from our AppVeyor feed.
are available. I think they'll meet your needs. |
|
@blairconrad thanks for the update. Do you have an ETA of the packages on NuGet.org? Ideally I'd like to avoid yet another package source, unless it's months away |
|
@thecodejunkie, unfortunately we do not. I understand your reluctance to add another package source, but had I to suggest a path today, I'd add it. |
|
@blairconrad after a short twitter exchange with @jonorossi it seems they were waiting on FakeItEasy, while you have been waiting on them. Maybe we can resolve this dead-lock? 😄 |
@blairconrad I had no idea you guys were waiting on a "stable" release, I was actually waiting on the 3 mocking libraries to have betas on nuget.org before going with a final release, especially that we made changes in beta002 for FakeItEasy. How did the AdditionalAttributes changes work out, did everything work well. This is actually the first time someone has asked me for an non-prerelease build. |
|
When I say a "beta" on nuget.org, I just meant any pre-release end users could try things out, especially since the Castle.Core package dependency gets exposed rather than ILMerged on .NET Core. Moq and NSubstitute have had alpha/beta/rc for a while. |
|
@blairconrad there wasn't really a discussion anywhere around this since I'm the only one driving the Castle ship, I've commented on the last remaining issue about deferring it until post-v4, but got no response so no one watching Castle Core had an opinion. I just thought it was a good idea to make sure all 3 mocking frameworks ship fully working in case we need to make breaking changes like beta002. If you want me to skip ahead without a FakeItEasy pre-release on nuget.org, then I'm okay with that. |
|
@jonorossi, I didn't comment on castleproject/Core#201 because I have no interest in the log4net integration, so I didn't want to butt in. Thanks for thinking of us mockers. The FakeItEasy owners have just had a conversation and we're going to work on a 3.0-prerelease (with .NET Standard support) for NuGet.org. We don't have a firm date (of course), but it should be soon enough that @thecodejunkie can wait to use the NuGet.org package pre-release package, and also for @jonorossi to wait on it for the Castle.Core 4.0 release. That is days, not weeks, before the pre-release package appears on NuGet.org. |
That issue was never in the v4 milestone, I assume you were thinking about the NLog not having a non-prerelease package one (castleproject/Core#200). We'll just downgrade NLog and remove .NET Core to ship Castle Core with only the Serilog adapter working on .NET Core, until NLog and log4net get their releases sorted.
Great, I'd be happy to cut the 4.0.0 final once Nancy has updated to that package, would be a good test with such a large codebase verifying FakeItEasy. I know it isn't the best way to run an OSS project but don't assume I've actually got plans for Castle releases, everything has been reactive based on what people want, just log an issue or ping me if you guys need something, I'll do my best to find the time to get what you need done. |
|
Yeah, we don't map out the releases either. Thanks for the offer, and your continued work! |
|
@jonorossi, @jchannon, in case you missed it, FakeItEasy 3.0.0-alpha001 is out. I've done no testing outside our usual release process, but if I find time today, will see if I can hook it up to NancyFx. Or vice versa. https://github.com/FakeItEasy/FakeItEasy/releases/tag/3.0.0-alpha001 |
|
I'm still asleep. Don't know why I put @jchannon in there when I meant @thecodejunkie. Apologies to whichever of you is most offended. |
|
I am offended beyond belief sir. I will see you at dawn for a dual. On Sun, 20 Nov 2016 at 13:22, Blair Conrad notifications@github.com wrote:
|
|
A duel would be more traditional. |
|
I blame the Github UI it cut off "carriageway drag race" On 20 November 2016 at 19:27, Adam Ralph notifications@github.com wrote:
|
|
👍 makes sense. I was thinking that you probably meant that, being more progressive than traditional. |
|
Unless I'm misinterpreting, this issue is "grab a project, add a more modern .NET Core-supporting framework section to it, and make the darn thing run", no? Which I feel is somewhat encouraging. If I'm actually doing something that's desired, I'll whip up a super rough PR in (my) morning. |
|
An update: FakeItEasy-3.0.0-beta002 has been released to NuGet. @NancyFx/owners, I know everyone's busy, and I don't mean to push, but is there something I've missed before the PR can be reviewed? (I am convinced you'll want changes, which I'm happy to make.) @jonorossi, I think that even without the changes to the PR, we've an indication that FakeItEasy can perform well in the context of the project. Does provide enough support for you to go ahead with the Castle.Core 4.0.0 release? |
|
@blairconrad yep thanks, will get it sorted in the next couple of days. |
|
Thanks, @jonorossi. No particular rush, but I wanted to know whether I was holding things up. 🐳 |
|
Apologies for the delay, Castle Core 4.0.0 final is available: http://www.castleproject.org/blog/2017/01/25/core-4.0.0-release/ |
Awesome, thanks @jonorossi! |
|
Yes! Thanks, @jonorossi! |
|
Sorry for dropping the ball on this (work/life stuff). What is needed from Nancy. Code review? Anything else? Can we perhaps create a checklist in #2634 of things that are needed so we can start ripping into it? 😍 |
|
@thecodejunkie, work and life happen. Don't worry. Assuming I've understood this whole issue, I think the next step is a review of #2634. I've surely done some things that are not correct or in keeping with Nancy's style. Where I'm aware of them, I've made notes in the review. I'm happy to change anything - no comment is too petty! But until I get some feedback from Team Nancy, I don't know what to adjust. |
|
Assuming #2713 is acceptable, I think the list upstairs could be updated to something like the following (I did not trace down whether components' 3rd-party requirements supported .NET Core or not; if the production project didn't have a .NET Standard project, I just stopped there).
The only outstanding item that I can see is running the .NET Core App Nancy.Embedded.Tests on Unix, and I have hit a wall there. |
|
Updated described from @blairconrad comment |
|
@horsdal you just beat me to merging #2713 and now updating this list! 👍 @blairconrad super thanks! |
|
@thecodejunkie, a pleasure. |
Description
We need to overhaul the test infrastructure, in the Nancy test projects, and make sure they all run the same version of xunit. We also need to bump the used version of FakeItEasy and re-enable all our tests on .NET Core.
Pre-requisits
Complete the migrations detailed in #2606 "Migrate remaining projects to support netstandard 1.6"
Required steps
packages.configto version2.2.0-beta2-build3300(this it the version we currently use in `project.json)project.jsonreally use2.2.0-beta2-build3300Nancy.*.Testsprojects to use FakeItEasy2.3.1(waiting for confirmation by @adamralph that this is the version we need for .NET Core)ℹ️ There is no need to bump the version of
dotnet-test-xunit, forproject.json, because we are already running the latest (2.2.0-preview2-build1029)TODO
(up this list and link any pull-requests that are sent to address the above)
ℹ️ Only send a pull-requests once you have confirmed that all the required steps (above) have been satisfied
Valid rejection status for each of the projects
Example
The text was updated successfully, but these errors were encountered: