fix(logs): truncate only non required properties #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Sep 20, 2024
| activityLogId: this.activityLogId, | ||
| log: { ...log, meta: truncateJson(log.meta) as MessageRowInsert['meta'] } | ||
| }); | ||
| } |
There was a problem hiding this comment.
should we also truncate request and response?
There was a problem hiding this comment.
mmh I didn't think about that indeed. It's annoying because truncating a json object is really slow, I wish we had a way to do path traversal and determine length without having to stringify each node.
Let's see if we need after this PR
hassan254-prog
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Describe your changes Fixes https://linear.app/nango/issue/NAN-1769/logs-truncation-removes-mandatory-fields - Only truncate `meta` object When truncating a log's JSON it would randomly remove mandatory properties if it was too big. Now we truncate only selected property, it's not yet bulletproof because people could send a large message and large `meta` object too. We should limit the message size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes https://linear.app/nango/issue/NAN-1769/logs-truncation-removes-mandatory-fields
metaobjectWhen truncating a log's JSON it would randomly remove mandatory properties if it was too big. Now we truncate only selected property, it's not yet bulletproof because people could send a large message and large
metaobject too. We should limit the message size