[Github Issue #554] improve dx #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "install:all": "npm i && cd packages/webapp && npm i && cd ../..", | ||
| "ts-build": "./node_modules/typescript/bin/tsc -b --clean packages/server packages/cli && ./node_modules/typescript/bin/tsc -b tsconfig.build.json && ./packages/webapp/node_modules/typescript/bin/tsc -b packages/webapp/tsconfig.json", | ||
| "ts-build": "tsc -b --clean packages/server packages/cli && tsc -b tsconfig.build.json && tsc -b packages/webapp/tsconfig.json", |
There was a problem hiding this comment.
That is going to use a global install of tsc, right? Is it better than using the repo one?
There was a problem hiding this comment.
Within the context of a npm script the executables in the node_modules/.bin directory are added to the PATH for execution so the repo tsc will be used here.
Reference: https://docs.npmjs.com/cli/v7/using-npm/scripts#path
bastienbeurier
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #554
git add -A .huskypre-commitcommand so a dev can stage only certain files and isn't forced to stage all files every single timeproviders.yamlfile is very important and that file should be tightly maintained.tsxfiles to be linted and adds--fixoption.envfile from source control to avoid accidental commits and use a.env.exampleinstead