Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution plotting scaling done separately in reference and analysis. #267

Closed
jakubnml opened this issue Mar 29, 2023 · 5 comments · Fixed by #369
Closed

Distribution plotting scaling done separately in reference and analysis. #267

jakubnml opened this issue Mar 29, 2023 · 5 comments · Fixed by #369
Labels
bug Something isn't working plotting Related with plotting functionality.

Comments

@jakubnml
Copy link
Contributor

Distribution plots are min-max scaled to nicely fill the horizontal space dedicated for each chunk. Here it seems that analysis and reference scaling is done separately which creates the illusion that distribution has changed between reference and first few chunks of analysis (became flat).

image

There are 2 possible solutions:

  1. Scale everything together. Then all the distributions are comparable and closest to the true distribution. The issue is that if for one or more chunks we observe a strong peak (like in the plot) every other distribution would be very flat (like in most analysis chunks in the plot).
  2. Scale every chunk separately - in that case every distribution fully fills the horizontal space dedicated for each chunk. The qualitative distribution comparison would be much easier - and that's the purpose of distribution plots. The weakness though is that frequency scales would be different for each chunk (I would say this is minor).
@jakubnml jakubnml added bug Something isn't working triage Needs to be assessed plotting Related with plotting functionality. labels Mar 29, 2023
@stale
Copy link

stale bot commented May 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 28, 2023
@stale stale bot closed this as completed Jun 4, 2023
@nikml nikml reopened this Jun 4, 2023
@stale stale bot removed the stale label Jun 4, 2023
@nnansters nnansters removed the triage Needs to be assessed label Jun 7, 2023
@nnansters
Copy link
Contributor

Let's see if we can get option 2 implemented then.

@nnansters nnansters removed their assignment Jun 7, 2023
@stale
Copy link

stale bot commented Aug 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 6, 2023
@nnansters nnansters removed the stale label Aug 6, 2023
@stale
Copy link

stale bot commented Oct 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 5, 2023
@stale stale bot closed this as completed Oct 12, 2023
@nnansters nnansters reopened this Oct 31, 2023
@nnansters nnansters removed the stale label Oct 31, 2023
Copy link

stale bot commented Dec 30, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

nnansters pushed a commit that referenced this issue Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plotting Related with plotting functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants