Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multiclass support for AP and BV #409

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Add Multiclass support for AP and BV #409

merged 11 commits into from
Jul 22, 2024

Conversation

nikml
Copy link
Contributor

@nikml nikml commented Jul 12, 2024

No description provided.

@nikml nikml added the enhancement New feature or request label Jul 12, 2024
@nikml nikml self-assigned this Jul 12, 2024
@nikml nikml requested a review from nnansters as a code owner July 12, 2024 21:59
# Conflicts:
#	tests/performance_calculation/metrics/test_multiclass_classification.py
#	tests/performance_estimation/CBPE/test_cbpe_metrics.py
replace forgotten model_output_column_names() with class_probability_columns property
No need for abbreviations here.
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 70.40816% with 87 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (3b0242b) to head (238ae8d).

Files Patch % Lines
...performance_estimation/confidence_based/metrics.py 70.19% 31 Missing and 14 partials ⚠️
...e_calculation/metrics/multiclass_classification.py 60.78% 22 Missing and 18 partials ⚠️
...annyml/sampling_error/multiclass_classification.py 94.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   77.24%   77.02%   -0.22%     
==========================================
  Files         109      109              
  Lines        9373     9663     +290     
  Branches     1684     1746      +62     
==========================================
+ Hits         7240     7443     +203     
- Misses       1668     1722      +54     
- Partials      465      498      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters
Copy link
Contributor

The test_cbpe_metrics module has become very very slow.

@nnansters nnansters merged commit 0750630 into main Jul 22, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants