Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in parsing configuration files due to Pydantic upgrade #421

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

nnansters
Copy link
Contributor

New treatment of Optional in Pydantic 2 was causing issues with the CLI.

This PR aims to fix that behavior.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (522a3bc) to head (cbde8b1).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
nannyml/config.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         109      109           
  Lines        9702     9702           
  Branches     1750     1750           
=======================================
  Hits         7250     7250           
  Misses       1965     1965           
  Partials      487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters merged commit c550e6c into main Sep 6, 2024
6 of 7 checks passed
@nnansters nnansters deleted the fix/pydantic-yaml-config-issues branch September 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant