separately delete forward dft chunk for adjoint optimization #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Sep 29, 2022
src/meepgeom.cpp
Outdated
| next_forward_chunk = current_forward_chunk->next_in_dft; | ||
| delete current_forward_chunk; | ||
| current_forward_chunk = next_forward_chunk; | ||
| } |
There was a problem hiding this comment.
Doesn't this need to set fields_f[i]->chunks = NULL or something?
|
Lines 182 to 190 in fba8aeb fields object, which is a bit different.
|
stevengj
reviewed
Oct 6, 2022
src/meepgeom.cpp
Outdated
| } | ||
| } | ||
|
|
||
| } // material_grids_addgradient | ||
|
|
||
| void delete_forward_dft_chunk(std::vector<meep::dft_fields *> fields_f) { |
There was a problem hiding this comment.
It seems like it would make more sense to have a dft_fields::delete_dft_chunks method, and then just call it for each element of the array.
stevengj
reviewed
Oct 6, 2022
| @@ -304,6 +304,13 @@ def calculate_gradient(self): | |||
| for ar in range(len(self.objective_functions)) | |||
| ] | |||
|
|
|||
| for dri in range(self.num_design_regions): | |||
| mp._delete_forward_dft_chunk( | |||
| self.forward_design_region_monitors[dri][0].swigobj, | |||
There was a problem hiding this comment.
Just call self.forward_design_region_monitors[dri][0].delete_dft_chunks() on each of the objects?
Codecov Report
@@ Coverage Diff @@
## master #2251 +/- ##
==========================================
+ Coverage 73.23% 73.24% +0.01%
==========================================
Files 17 17
Lines 4916 4919 +3
==========================================
+ Hits 3600 3603 +3
Misses 1316 1316
|
stevengj
reviewed
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2097. Delete forward dft chunks at the end of all adjoint gradients calculation.