Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #1

Closed
wants to merge 3 commits into from
Closed

Small fixes #1

wants to merge 3 commits into from

Conversation

FilipDominec
Copy link

Two small fixes and one new feature:

  • I could not convince autogen.sh to pass --prefix=/usr/local to configure.sh, which is important to me
  • the premature termination of optimisation with 'Finished solve_cw after 1 steps and 0 CG iters' was reported about a year ago; until the newly written code in 1.2.1 works, I suggest to fall back to the norm2() function from MEEP 1.1.1
  • band-src-time uses the sine-integral time function to provide well-defined rectangular spectrum (see http://fzu.cz/~dominecf/misc/meep/index.html#bandsource for examples)

double tt = time - peak_time;

// The function that introduces a rectangular band in the spectrum (centered around zero frequency)
#ifdef HAVE_LIBGSL_EXPINT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should really be a configure check for this.

@stevengj
Copy link
Collaborator

Please use separate pull requests for different features (i.e. 3 pull requests in this case), so that they can be reviewed, discussed, and merged independently.

I'll close this so that you can resubmit as distinct PRs.

@stevengj stevengj closed this Apr 10, 2014
stevengj added a commit that referenced this pull request Apr 10, 2014
@stevengj
Copy link
Collaborator

As noted above, I've fixed 2 of the 3 issues that you mention by recent commits, so please submit a PR just on the new source that you want to provide, so that we can discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants