Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove verbose argument from meepgeom::set_materials_from_geometry #1000

Merged
merged 3 commits into from
Aug 28, 2019
Merged

remove verbose argument from meepgeom::set_materials_from_geometry #1000

merged 3 commits into from
Aug 28, 2019

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Aug 24, 2019 •
edited
Loading

Removes the verbose argument from set_materials_from_geometry in src/meepgeom.cpp which had been left out of #994 and is no longer necessary. The geometric-object tree information is only displayed when verbosity = 2. This should be merged after #997.

Two other places where the verbose argument should also be removed:

  1. geom_epsilon in scheme/structure.cpp

  2. get_eigenmode and get_eigenmode_coefficients in src/mpb.cpp

@stevengj
Copy link
Collaborator

Let's print it on verbosity > 2

@stevengj stevengj merged commit 04c3c0c into NanoComp:master Aug 28, 2019
@oskooi oskooi deleted the remove_verbose branch August 28, 2019 04:13
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@oskooi @stevengj
remove verbose argument from meepgeom::set_materials_from_geometry (N…
d522a88 
…anoComp#1000)

* remove verbose argument from meepgeom::set_materials_from_geometry

* fixes

* less verbose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskooi @stevengj